[OE-core] [PATCH] gptfdisk: add 0.8.10+git version

Joshua Hernstrom joshua.hernstrom at ni.com
Fri Nov 7 18:10:40 UTC 2014


Hi Koen,

> Besides from being useful as fdisk replacement this gives us 'sgdisk'
> which can be used to set the GUID for partitions, e.g.
> 
> 	sgdisk -t 1:C12A7328-F81F-11D2-BA4B-00A0C93EC93B /dev/mmcblk0p1
> 
> To mark it as ESP in scripts like mkefidisk.sh.
> 
> Signed-off-by: Koen Kooi <koen at ...>
> ---
>  meta/recipes-devtools/fdisk/gptfdisk_git.bb | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 meta/recipes-devtools/fdisk/gptfdisk_git.bb
> 
> diff --git a/meta/recipes-devtools/fdisk/gptfdisk_git.bb
> b/meta/recipes-devtools/fdisk/gptfdisk_git.bb new file mode 100644
> index 0000000..62c32c3
> --- /dev/null
> +++ b/meta/recipes-devtools/fdisk/gptfdisk_git.bb
>  <at>  <at>  -0,0 +1,22  <at>  <at> 
>...
> +S = "${WORKDIR}/git"
> +
> +do_install() {
> +    install -d ${D}${bindir}
> +    install -m 0755 cgdisk ${D}${bindir}
> +    install -m 0755 gdisk ${D}${bindir}
> +    install -m 0755 sgdisk ${D}${bindir}
> +    install -m 0755 fixparts ${D}${bindir}

Have you considered splitting this package into separate sub-packages? The util-linux recipe does something similar for the fdisk family of utilities. I had a not-yet-submitted recipe along the same line as yours - the relevant snippets follow for reference:

<snip>
PACKAGES =+ "${PN}-gdisk ${PN}-cgdisk ${PN}-sgdisk ${PN}-fixparts"
FILES_${PN}-gdisk = "${sbindir}/gdisk"
FILES_${PN}-cgdisk = "${sbindir}/cgdisk"
FILES_${PN}-sgdisk = "${sbindir}/sgdisk"
FILES_${PN}-fixparts = "${sbindir}/fixparts"

do_install() {
	install -m 0755 -d ${D}${sbindir}
	sbinprogs="gdisk cgdisk sgdisk fixparts"
	for f in ${sbinprogs}; do
		install -m 0755 ${S}/${f} ${D}${sbindir}
	done
}
</snip>

Cheers,
Josh
--
Joshua Hernstrom
National Instruments



More information about the Openembedded-core mailing list