[OE-core] [PATCH] Bluez5: Add gatttool to new package bluez5-tools
Qian Lei
qianl.fnst at cn.fujitsu.com
Mon Nov 10 05:52:37 UTC 2014
On Fri, 7 Nov 2014 12:42:14 +0000
"Burton, Ross" <ross.burton at intel.com> wrote:
> On 4 November 2014 05:04, Qian Lei <qianl.fnst at cn.fujitsu.com> wrote:
>
> > # at_console doesn't really work with the current state of OE, so
> > punch some more holes so people can actually use BT
> > + install -m 0755 ${S}/attrib/gatttool ${D}/${bindir}/
> > install -m 0644 ${WORKDIR}/bluetooth.conf
> > ${D}/${sysconfdir}/dbus-1/system.d/
> > }
> >
>
> Because of where you put the install, it looks like installing gatttool is
> related to the DBus configuration.
Hi Ross, thank you for your review.
Sorry for making you confused, the install should be put before the comment. I
just want to install gatttool to bin directory and it is nothing related to
dbus. I'll correct it in the next version.
> > ALLOW_EMPTY_libasound-module-bluez = "1"
> > -PACKAGES =+ "libasound-module-bluez ${PN}-testtools ${PN}-obex"
> > +PACKAGES =+ "libasound-module-bluez ${PN}-testtools ${PN}-obex
> > ${PN}-tools"
> >
>
> Two questions:
> 1) If we're installing gatttool, why not the other tools that are noinst
> (obex-client-tool, obexctl, etc). Patching the makefile would install all
> the tools that upstream build.
Because in bluez4, gatttool was installed by default but obex-client-tool,
obexctl were not.
> 2) Do these deserve a separate package, or as they're for testing should
> they go into PN-testtools?
gatttool is not a test tool, but a develop tool. In bluez4 it is in package
bluez4(not in bluez4-testtools). I don't think it's good to put it to any
existed package.
Qian Lei.
More information about the Openembedded-core
mailing list