[OE-core] [daisy][PATCH 1/3] layer.conf: Add in useradd dependencies as ABISAFE dependencies

Martin Jansa martin.jansa at gmail.com
Wed Oct 1 04:10:20 UTC 2014


On Tue, Sep 30, 2014 at 08:55:53PM -0700, Khem Raj wrote:
> On Tue, Sep 30, 2014 at 6:32 PM, Denys Dmytriyenko <denis at denix.org> wrote:
> > On Tue, Sep 30, 2014 at 06:25:57PM -0700, Khem Raj wrote:
> >> On Tue, Sep 30, 2014 at 5:55 PM, Denys Dmytriyenko <denis at denix.org> wrote:
> >> > This line above ^^^^ has a very long trail of whitespaces and it got commited
> >> > that way, unfortunately :(
> >>
> >> Better was if you commented before it went in.
> >
> > And how would you suggest I was supposed to see it?? Nobody saw it. My email
> > client is no different than others - it doesn't mark trailing whitespaces. The
> > reason I saw it is because I ran "git log -p" on the file and that explicitly
> > highlights trailing whitespaces in BRIGHT RED... :)
> 
> just for that may be we should start using gerrit ;)

I'm all for it, it would make my e-mail - review - patchwork -
master-next workflow a lot easier and reliable.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20141001/1982a4ba/attachment-0002.sig>


More information about the Openembedded-core mailing list