[OE-core] Request to move "gitpkgv.bbclass" from meta-oe to oe-core

Paul Eggleton paul.eggleton at linux.intel.com
Fri Oct 10 15:03:25 UTC 2014


Hi Mike,

On Friday 10 October 2014 07:36:25 Mike Looijmans wrote:
> On 10/10/2014 12:15 AM, Otavio Salvador wrote:
> > On Thu, Oct 9, 2014 at 4:56 PM, Richard Purdie
> > 
> > <richard.purdie at linuxfoundation.org> wrote:
> >> On Thu, 2014-10-09 at 10:16 +0200, Mike Looijmans wrote:
> >>> In partial reply to my own question, this has been discussed 2 years
> >>> ago, but apparently nothing ever came out of it.
> >>> 
> >>> http://lists.openembedded.org/pipermail/openembedded-core/2012-February/
> >>> 056050.html
> >>> 
> >>> So once more the request to be able to get sane version strings for git
> >>> repos. Can we please just move gitpkgv. That's like five minutes work,
> >>> and if anyone (e.g. me) feels like building something better, he or she
> >>> is free do submit that and get rid of the gitpkgv class once it's
> >>> obsolete.
> >> 
> >> I do feel quite strongly that this is something which should get
> >> improved in the fetcher itself. That is why I've pushed back on the
> >> patch since if I take it into OE-Core, there is even less incentive to
> >> fix the real problem...
> > 
> > Mike I am also an user of gitpkgv but I must to agree with Richard
> > here. Moving this to OE-Core will just make it worse. It is way better
> > to prepare a patch and add support for it on the fetcher code of
> > BitBake.
> 
> Give me some pointers on what you're talking about here, and I'll be happy
> to try and implement it. Currently I have no idea as to what is "wrong"
> with the gitpkgv approach, and I also have no clue as to what it is you
> want to have implemented in the git fetcher.

The code would go into the fetcher itself i.e. lib/bb/fetch2/git.py and 
lib/bb/fetch2/__init__.py. 

I'm not sure whether it would be a case of setting a variable in order to have 
the value of SRCPV within OE (which calls bb.fetch2.get_srcrev() ) return the 
"git describe" style version instead of the current one, or whether we would 
preserve the separate GITPKGVTAG variable for that purpose. (The GITPKGV case 
is already handled by the current behaviour of SRCPV, right?)

FWIW there is an open bug covering this issue:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=2872

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



More information about the Openembedded-core mailing list