[OE-core] [PATCH 1/7] kernel: Clean up KERNEL_IMAGETYPE_FOR_MAKE

[Otavio Salvador]

On Sun, Oct 19, 2014 at 7:13 PM, Marek Vasut <marex at denx.de> wrote:
> On Sunday, October 19, 2014 at 09:25:36 PM, Otavio Salvador wrote:
>> On Sun, Oct 19, 2014 at 5:15 PM, Marek Vasut <marex at denx.de> wrote:
>> > Remove the lambda function setting KERNEL_IMAGETYPE_FOR_MAKE and instead
>> > set it in the anonymous python function. This also allows us to handle
>> > image types which are not supported directly by kernel, but require some
>> > other kernel target to be built. This is the case for example with the
>> > fitImage, which is the uImage successor.
>> >
>> > There is no functional change.
>>
>> This is not really what the code shows; your regexp is more permissive
>> than the previous lambda.
>
> Do you happen to have a suggestion how to improve the patch please ? I'm
> not really a python guru so any help is welcome ...

I like the code, just the commit log needs improvement as you did
change the functionality here.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750