[OE-core] [PATCH 4/7] kernel: Pull uImage generation into separate class

[Bruce Ashfield]

On Sun, Oct 19, 2014 at 6:29 PM, Marek Vasut <marex at denx.de> wrote:
> On Monday, October 20, 2014 at 12:08:57 AM, Bruce Ashfield wrote:
>> On Sun, Oct 19, 2014 at 3:15 PM, Marek Vasut <marex at denx.de> wrote:
>> > Pull the uImage image format generation from kernel.bbclass into
>> > a separate kernel-uimage.bbclass. The recipes which now need to
>> > generate an uImage will have to inherit kernel-uimage instead of
>> > kernel class.
>>
>> The commit log doesn't tell us why. What's the benefit or functionality we
>> gain via the change ?
>
> Ah right. I will be recycling some of those functions later on in the fitImage

Yep. And that's what is missing from the commit log. As a standalone commit,
the reader is left wondering why.

> support. Also, it was suggested to me that there should be a separate class for
> each image type -- that all the image types should not be in kernel.bbclass .

Factoring code and cleanups are great .. but sometimes it is just churn. I've
never had any problems with the image code being in a single class. So if
things are broken out, it would be nice to have a technical reason or
new feature
to go along with the changes.

Bruce

>
> Does that make sense please?
>
> Best regards,
> Marek Vasut



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"