[OE-core] [PATCH 1/1] lsof: fix LSOF_CCV in version.h

Burton, Ross ross.burton at intel.com
Wed Oct 22 20:03:28 UTC 2014


On 22 October 2014 04:23, <wenzong.fan at windriver.com> wrote:

> +-      @echo '#define  LSOF_CCV        "${CCV}"' >> version.h
> ++      @LSOF_CCV=`${CC} -v 2>&1 | sed -n 's/.*version \(.*\)/\1/p'` &&\
> ++      echo "#define   LSOF_CCV        \"${LSOF_CCV}\"" >> version.h
>

It seems that a better (and importantly, upstreamable) fix would be to pass
LSOF_CC correctly to ./Configure instead of overriding in do_compile(), and
change the LSOF_CCV assignment to run LSOF_CC if _CCV isn't already set.

(My general approach here is spend a little more time getting a fix
upstreamed so that we're not fixing our patch every few months)

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20141022/cb9f9f1c/attachment-0002.html>


More information about the Openembedded-core mailing list