[OE-core] [PATCH 25/26] run-postinsts.service: remove redundant line

ChenQi Qi.Chen at windriver.com
Wed Sep 3 02:50:22 UTC 2014


On 09/03/2014 01:17 AM, Burton, Ross wrote:
> On 2 September 2014 11:54, Chen Qi <Qi.Chen at windriver.com> wrote:
>> The basic.target itself requires sysinit.target, so there's no
>> need to write this redundant line in the run-postinsts unit file.
>>
>> Signed-off-by: Chen Qi <Qi.Chen at windriver.com>
>> ---
>>   meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service
>> index 822327a..85a0439 100644
>> --- a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service
>> +++ b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts.service
>> @@ -13,5 +13,4 @@ RemainAfterExit=No
>>   TimeoutSec=0
>>
>>   [Install]
>> -WantedBy=basic.target
>>   WantedBy=sysinit.target
> >From the commit message it sounds like you meant to remove
> sysinit.target.  What is correct?
>
> Ross
>
>

Removing 'WantedBy=basic.target' is correct.

As sysinit.target is required by basic.target, and run-postinsts.service 
is required by sysinit.target, then
run-postinsts.service has been in the dependency chain of basic.target.
So there's no need to write 'WantedBy=basic.target'.

Best Regards,
Chen Qi



More information about the Openembedded-core mailing list