[OE-core] [PATCH] kmod: remove the setting of INHIBIT_PACKAGE_STRIP

[Tudor Florea]

Hi

> -----Original Message-----
> From: Burton, Ross [mailto:ross.burton at intel.com]
> Sent: Monday, September 15, 2014 17:32
> To: rongqing.li at windriver.com
> Cc: OE-core; Tudor Florea
> Subject: Re: [OE-core] [PATCH] kmod: remove the setting of
> INHIBIT_PACKAGE_STRIP
> 
> On 15 September 2014 09:27,  <rongqing.li at windriver.com> wrote:
> > From: Roy Li <rongqing.li at windriver.com>
> >
> > Setting INHIBIT_PACKAGE_STRIP is added by 61cb45869c[kmod: ptest
> fixes], but I
> > can not reproduce the described issue, and seems it make wrong logical [
> > when enable ptest, INHIBIT_PACKAGE_STRIP is always 1; and when disable
> ptest,
> > INHIBIT_PACKAGE_STRIP is always 0]
> >
> > Cc: Tudor Florea <tudor.florea at enea.com>
> 
> As Tudor added this I'd love to hear from them about this, but I can
> confirm that this patch doesn't cause warnings with ptest enabled.
> 
[Tudor Florea] It is hard to remember the exact rationale at this moment that the comment should be self-explanatory:
"Since kmod test files contain kernel modules for many different architectures, strip and arch gets confused and throws errors"
It means nothing if a specific platform doesn't exhibit the behavior. Kmod ptest attempts to load a precompiled (and unstripped for that matter) inappropriate module and verify this is not possible. I still think we should not remove the line (e.g. we should not alter kmod precompiled modules from ptest).

Regards,
  Tudor.

> Ross