[OE-core] [PATCH v2 6/8] blktrace: obey LDFLAGS for btrecord

Khem Raj raj.khem at gmail.com
Fri Sep 19 04:42:05 UTC 2014


On Thu, Sep 18, 2014 at 1:51 PM, Christopher Larson <clarson at kergoth.com> wrote:
>
> On Thu, Sep 18, 2014 at 12:26 AM, Khem Raj <raj.khem at gmail.com> wrote:
>>
>> On 9/16/14 6:17 PM, Christopher Larson wrote:
>> > From: Christopher Larson <chris_larson at mentor.com>
>> >
>> > Signed-off-by: Christopher Larson <chris_larson at mentor.com>
>> > ---
>> >  meta/recipes-kernel/blktrace/blktrace/ldflags.patch | 8 ++++++--
>> >  1 file changed, 6 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/meta/recipes-kernel/blktrace/blktrace/ldflags.patch
>> > b/meta/recipes-kernel/blktrace/blktrace/ldflags.patch
>> > index b9c7c20..037d161 100644
>> > --- a/meta/recipes-kernel/blktrace/blktrace/ldflags.patch
>> > +++ b/meta/recipes-kernel/blktrace/blktrace/ldflags.patch
>> > @@ -59,8 +59,12 @@ Signed-off-by: Fahad Usman <fahad_usman at mentor.com>
>> >   INCS        = -I. -I.. -I../btt
>> >   OCFLAGS     = -UCOUNT_IOS -UDEBUG -DNDEBUG
>> >   XCFLAGS     = -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
>> > -@@ -35,7 +36,7 @@ btrecord: btrecord.o
>> > -     $(CC) $(CFLAGS) -o $@ $(filter %.o,$^)
>> > +@@ -32,10 +33,10 @@ clean: docsclean
>> > +     $(CC) $(CFLAGS) -c -o $*.o $<
>> > +
>> > + btrecord: btrecord.o
>> > +-    $(CC) $(CFLAGS) -o $@ $(filter %.o,$^)
>> > ++    $(CC) $(CFLAGS) -o $@ $(filter %.o,$^) $(LDFLAGS)
>> >
>>
>> aren't you passing LDFLAGS to compile step as well here ?
>
>
> I don't think so. This rule creates btrecord from btrecord.o, it doesn't
> compile btrecord.c to btrecord.o, that's an entirely different rule.

thats right. I confused it with filter



More information about the Openembedded-core mailing list