[OE-core] [oe-core][PATCH] cmake.bbclass : Add support for cmake projects that use .S files.

[Otavio Salvador]

On Fri, Sep 19, 2014 at 10:55 AM, Philip Balister <philip at balister.org>
wrote:

> On 09/17/2014 07:07 PM, Khem Raj wrote:
> > On Wed, Sep 17, 2014 at 7:33 AM, Philip Balister <philip at balister.org>
> wrote:
> >> UHD and GNU radio use the cmake build system. The toolchain file made
> >> from cmake.bbclass does not set the variable needs by cmake projects
> >> that use .S files. UHD added some .S files and these changes are
> required
> >> to build recent UHD.
> >>
> >
> > I dont know if this is right thing to do in a generic bbclass. Since
> > some packages might use bare assembler to compiler assembly files
>
> If a cmake project enables assembler and doesn't set the CMAKE_ASM_*
> flags to some sane defaults, the build fails. Settings these vars in the
> toolchain files fixes the problem.
>
> I am not a cmake guru, but it seems like we should be able to build code
> that builds OK natively.
>

I agree with Philip;  I think a sane default makes more sense than a broken
build.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20140919/488edd8c/attachment-0002.html>