[OE-core] [PATCH] kernel.bbclass: use one package split for all firmware filename extensions

Peter A. Bigot pab at pabigot.com
Tue Sep 23 17:06:07 UTC 2014


On 09/23/2014 11:38 AM, Denys Dmytriyenko wrote:
> On Sun, Sep 21, 2014 at 01:08:55PM +0200, Carlos Rafael Giani wrote:
>> Signed-off-by: Carlos Rafael Giani <dv at pseudoterminal.org>
>> ---
>>   meta/classes/kernel.bbclass | 5 +----
>>   1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 4710719..78b33ce 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -384,10 +384,7 @@ pkg_postrm_kernel-image () {
>>   PACKAGESPLITFUNCS_prepend = "split_kernel_packages "
>>   
>>   python split_kernel_packages () {
>> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.bin$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.fw$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.cis$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.dsp$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> +    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.(bin|fw|cis|dsp)$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
> Can we also add .elf to the list? Thanks!

Related to that: I noticed that the meta-ti kernel adds a firmware blob 
am335x-pm-firmware.elf.  This causes QA errors when building that kernel 
with linux-yocto because the .elf file is stripped and the unstripped 
debug version isn't packaged.

The existing linux-firmware repository doesn't include any elf format 
files.  Perhaps the TI module could be updated to load the .bin version 
of the file instead.

Peter




More information about the Openembedded-core mailing list