[OE-core] [PATCH v2] ltp: add PACKAGECONFIG for numactrl
Burton, Ross
ross.burton at intel.com
Thu Sep 25 22:55:49 UTC 2014
On 25 September 2014 02:20, <rongqing.li at windriver.com> wrote:
> ++AC_ARG_WITH([numa],
> ++ [AC_HELP_STRING([--with-numa],
> ++ [have the numa support (default=no)])],
> ++ [with_numa="${withval}"],
> ++)
I suggest reading
http://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/External-Software.html
as this doesn't quite do what you expect - or more accurately it does
what you want but is flakey.
A more accurate way of expressing what you want and preserving
existing behaviour is:
AC_ARG_WITH([numa], [AC_HELP_STRING([--without-numa], [disable NUMA
support (default=yes)])],[],[with_numa=yes])
The original code checks so default the option to yes. You don't need
to pass anything for the action-if-given argument as the default
behaviour is what you want.
I also prefer --with-numa and --without-numa for the PACKAGECONFIG
option as that's super-clear what's happening.
Finally can you rebase to master as other LTP patches have been merged
and this doesn't apply.
Ross
More information about the Openembedded-core
mailing list