[OE-core] [PATCH 5/5] bluetooth.bbclass: set bluez5 as the default BT stack

[Iorga, Cristian]

The aforementioned packageconfigs are just examples/guidelines, we added code for diverse recipes on a case by case scenario.

-----Original Message-----
From: Tanu Kaskinen [mailto:tanu.kaskinen at linux.intel.com] 
Sent: Tuesday, April 7, 2015 1:27 PM
To: Iorga, Cristian
Cc: openembedded-core at lists.openembedded.org
Subject: Re: [OE-core] [PATCH 5/5] bluetooth.bbclass: set bluez5 as the default BT stack

On Fri, 2015-04-03 at 17:13 +0300, Cristian Iorga wrote:
>  # Use this with:
>  #  inherit bluetooth
>  #  PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 
> 'bluetooth', '${BLUEZ}', '', d)}  #  PACKAGECONFIG[bluez4] = "--enable-bluez4,--disable-bluez4,bluez4"
> +# if the obsolete, but still supported bluez4 BT stack is used # or #  
> +inherit bluetooth #  PACKAGECONFIG ??= 
> +"${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', '${BLUEZ}', '', 
> +d)} #  PACKAGECONFIG[bluez5] = "--enable-bluez5,--disable-bluez5,bluez5"
> +# if the default bluez5 BT stack is used

I don't think this documentation is correct. It makes it sound like a recipe should only have

    PACKAGECONFIG[bluez4] = "--enable-bluez4,--disable-bluez4,bluez4"

or

    PACKAGECONFIG[bluez5] = "--enable-bluez5,--disable-bluez5,bluez5"

, while in reality the recipe should have both lines.

So, I think the documentation should be written like this:

# Use this with:
#  inherit bluetooth
#  PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', '${BLUEZ}', '', d)} #  PACKAGECONFIG[bluez4] = "--enable-bluez4,--disable-bluez4,bluez4"
#  PACKAGECONFIG[bluez5] = "--enable-bluez5,--disable-bluez5,bluez5"

--
Tanu