[OE-core] [PATCH 5/5] bluetooth.bbclass: set bluez5 as the default BT stack

[Martin Jansa]

On Tue, Apr 07, 2015 at 03:46:06PM +0300, Tanu Kaskinen wrote:
> On Tue, 2015-04-07 at 14:44 +0200, Martin Jansa wrote:
> > On Tue, Apr 07, 2015 at 03:36:31PM +0300, Tanu Kaskinen wrote:
> > > This would be more appropriate for recipes that only support bluez4:
> > > 
> > > #  inherit bluetooth
> > > #  PACKAGECONFIG ??= "${@bb.utils.contains('BLUEZ', 'bluez4', 'bluez4, '', d}"
> > > #  PACKAGECONFIG[bluez4] = "--enable-bluez4,--disable-bluez4,bluez4"
> > 
> > The last example isn't correct, because you still need to respect
> > 'bluetooth' in 'DISTRO_FEATURES' before enabling whatever is in BLUEZ
> > variable.
> 
> BLUEZ is empty if 'bluetooth' is not in DISTRO_FEATURES, so my example
> should work fine.

The default value is, but that doesn't ensure that user has different
value set in local.conf and suddenly his bluetooth-less distro
configuration is trying to enable bluez* support in some component.

So for consistency sake you should respect bluetooth in DISTRO_FEATURES
(like in the previous example).

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20150407/c836a649/attachment-0002.sig>