[OE-core] [PATCH] runqemu: Add error handling for unexpected tap devices

Khem Raj raj.khem at gmail.com
Sun Aug 9 07:31:10 UTC 2015


> On Aug 9, 2015, at 12:03 AM, Richard Purdie <richard.purdie at linuxfoundation.org> wrote:
> 
> In theory the code reduces the tap device number to an integer. This
> patch adds error checking to ensure that does happen and that the script
> exits if something unexpected happens.
> 

I see these patches are already on master. Are you sending them again by mistake for review or something else ?

> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> 
> diff --git a/scripts/runqemu-internal b/scripts/runqemu-internal
> index 03b40d8..0ace485 100755
> --- a/scripts/runqemu-internal
> +++ b/scripts/runqemu-internal
> @@ -253,6 +253,14 @@ else
> 
> 
>         n0=$(echo $TAP | sed 's/tap//')
> +
> +        case $n0 in
> +            ''|*[!0-9]*)
> +                echo "Error Couldn't turn $TAP into an interface number?"
> +                exit 1
> +                ;;
> +        esac
> +
>         n1=$(($n0 * 2 + 1))
>         n2=$(($n1 + 1))
> 
> 
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20150809/db18dd91/attachment-0002.sig>


More information about the Openembedded-core mailing list