[OE-core] [PATCH] kernel.bbclass: Fix do_shared_workdir task ordering

[Bruce Ashfield]

On Mon, Aug 10, 2015 at 11:21 AM, Stefan Müller-Klieser
<s.mueller-klieser at phytec.de> wrote:
> commit 02d0a003d60326 [kernel.bbclass: Fix race condition] has surfaced
> a bug in the generation of the shared_workdir. The task
> do_compile_kernelmodules adds the exported symbols of the kernel modules
> to the Module.symvers. By creating the shared_workdir before the modules
> are compiled, the symbols of the modules are missing in the
> shared_workdir. Subsequent external module builds will not include the
> ABI CRC of functions exported in modules. Modprobe will fail to load the
> external module if CONFIG_MODVERSIONS is enabled.\

Have you seen our bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8127 ?

It's new .. so probably not.

The significant issue with this, is that we are now forcing anyone
that needs the
shared workdir artifacts to build kernel modules.

That's performance issue for many workflows.

I had some changes where I was working to short cut parts of the process, but
they turned out to miss a few corner cases.

We need to do more thinking on this one, before we can bring in a change like
this .. since avoiding that overhead is something valuable.

Cheers,

Bruce


>
> Signed-off-by: Stefan Müller-Klieser <s.mueller-klieser at phytec.de>
> ---
>  meta/classes/kernel.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index d06f6cf..473f1f8 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -249,7 +249,7 @@ kernel_do_install() {
>  }
>  do_install[prefuncs] += "package_get_auto_pr"
>
> -addtask shared_workdir after do_compile before do_compile_kernelmodules
> +addtask shared_workdir after do_compile_kernelmodules before do_install
>  addtask shared_workdir_setscene
>
>  do_shared_workdir_setscene () {
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"