[OE-core] [PATCH 2/2] base.bbclass/blacklist.bbclass: remove doc item when d.getVarFlags()

[Otavio Salvador]

On Wed, Aug 12, 2015 at 11:04 AM, Paul Eggleton
<paul.eggleton at linux.intel.com> wrote:
> On Wednesday 12 August 2015 10:45:29 Otavio Salvador wrote:
>> On Tue, Aug 11, 2015 at 11:13 PM, Robert Yang <liezhi.yang at windriver.com>
> wrote:
>> > On 08/11/2015 08:45 PM, Otavio Salvador wrote:
>> >> On Thu, Jul 30, 2015 at 12:18 PM, Robert Yang <liezhi.yang at windriver.com>
>> >>
>> >> wrote:
>> >>> The FOO[doc] is set in meta/conf/documentation.conf, we need remove it
>> >>> from d.getVarFlags()'s return dict when it causes many loops.
>> >>>
>> >>> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
>> >>
>> >> It seems your commit log is incomplete or so as I couldn't understand
>> >> why this is need.
>> >>
>> >> Also as Andre says, we ought to not break existing layer without a
>> >> very strong reason and if needed, changing documentation.conf instead
>> >> of this seems more adequate.
>> >
>> > The code in base.bbclass is: (no remove PACKAGECONFIG[doc])
>> >
>> >     pkgconfigflags = d.getVarFlags("PACKAGECONFIG") or {}
>> >
>> >     if pkgconfigflags:
>> >        <foo>
>> >
>> > And documentation.conf:
>> > PACKAGECONFIG[doc] = "This variable provides a means of enabling or
>> > disabling features of a recipe on a per-recipe basis."
>> >
>> > This will make "if pkgconfigflags:" always be true and cause many unneeded
>> > loops since there is always PACKAGECONFIG[doc].
>> >
>> > Remove PACKAGECONFIG[doc] or comment it sounds good to me.
>>
>> So documentation.conf needs change.
>
> I'm not sure I'm particularly happy with this. Whilst its actual practical use
> is relatively recent (i.e. Toaster), documentation.conf and the doc varflag
> predate PACKAGECONFIG by quite some time. The fact that one layer has gone and
> used it is unfortunate but not unfixable.

I understand but this kind of magic keyword is misleading and
confusing for users.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750