[OE-core] [PATCH] Rename 'BRANCH' variable to 'SRC_BRANCH' for clearness

Khem Raj raj.khem at gmail.com
Sat Aug 22 06:03:17 UTC 2015


> On Aug 21, 2015, at 2:58 PM, Otavio Salvador <otavio.salvador at ossystems.com.br> wrote:
> 
> On Fri, Aug 21, 2015 at 6:49 PM, Khem Raj <raj.khem at gmail.com> wrote:
>> 
>>> On Aug 21, 2015, at 2:38 PM, Otavio Salvador <otavio at ossystems.com.br> wrote:
>>> 
>>> The 'BRANCH' variable name has no explicit relation with the
>>> SRC_URI. Using 'SRC_BRANCH' makes it more obvious and easier to
>>> identify.
>> 
>> Look good to me, just may be avoid ‘_’ and call it SRCBRANCH
> 
> I did this initially but looking at how it looks in the source code,
> it seems SRC_BRANCH makes easier to spot the relation with SRC_URI. So
> I took the second.

since bitbake use ‘_’ as a override separator, its less confusing if variables don’t have underscore in them
for future collision.

> 
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20150821/0f45585f/attachment-0002.sig>


More information about the Openembedded-core mailing list