[OE-core] [PATCH] mtd-utils: add dependency on acl

[Andrea Adami]

On Sat, Aug 22, 2015 at 11:50 AM, Andrea Adami <andrea.adami at gmail.com>
wrote:

>
>
> On Sat, Aug 22, 2015 at 11:47 AM, Andrea Adami <andrea.adami at gmail.com>
> wrote:
>
>>
>>
>> On Sat, Aug 22, 2015 at 2:44 AM, Andre McCurdy <armccurdy at gmail.com>
>> wrote:
>>
>>> On Fri, Aug 21, 2015 at 4:28 PM, Andrea Adami <andrea.adami at gmail.com>
>>> wrote:
>>> > After commit 24fde4d do_compile fails:
>>> >
>>> > | mkfs.jffs2.c:70:21: fatal error: sys/acl.h: No such file or directory
>>> > |  #include <sys/acl.h>
>>> >
>>> > Adding acl to the list of dependencies fixes the build.
>>>
>>> Unconditionally enabling xattr and acl support is OK for the native
>>> build, but for the target both should probably be conditional on their
>>> respective DISTRO_FEATURES.
>>>
>>
>> I can agree, acl is one distro feature but atm it is not used by nodistro
>> and poky.
>> So the patch unconditionally  -DWITHOUT_XATTR seems wrong...this should
>> be done only if acl is used.
>>
>
>
> ofc I meant unconditionally removing -DWITHOUT_XATTR
> ( commit24fde4d983cc8f056177de6c1ad308369f6279ad )
> <http://cgit.openembedded.org/openembedded-core/commit/meta/recipes-devtools/mtd/mtd-utils_git.bb?id=24fde4d983cc8f056177de6c1ad308369f6279ad>
>
>
>>
>> Andrea
>>
>>
>>
>>>
>>>
>>> > Signed-off-by: Andrea Adami <andrea.adami at gmail.com>
>>> > ---
>>> >  meta/recipes-devtools/mtd/mtd-utils_git.bb | 2 +-
>>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>>> >
>>> > diff --git a/meta/recipes-devtools/mtd/mtd-utils_git.bb
>>> b/meta/recipes-devtools/mtd/mtd-utils_git.bb
>>> > index 8d4892a..72ce9ed 100644
>>> > --- a/meta/recipes-devtools/mtd/mtd-utils_git.bb
>>> > +++ b/meta/recipes-devtools/mtd/mtd-utils_git.bb
>>> > @@ -5,7 +5,7 @@ LICENSE = "GPLv2+"
>>> >  LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>>> >
>>> file://include/common.h;beginline=1;endline=17;md5=ba05b07912a44ea2bf81ce409380049c"
>>> >
>>> > -DEPENDS = "zlib lzo e2fsprogs util-linux"
>>> > +DEPENDS = "zlib lzo e2fsprogs util-linux acl"
>>> >
>>> >  PV = "1.5.1+git${SRCPV}"
>>> >
>>> > --
>>> > 1.9.1
>>> >
>>> > --
>>> > _______________________________________________
>>> > Openembedded-core mailing list
>>> > Openembedded-core at lists.openembedded.org
>>> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>
>>
>
Please ignore, patch v2 will be sent now.
Cheers

Andrea
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20150822/50e2c9e2/attachment-0002.html>