[OE-core] [PATCH 1/5] image.py: write bitbake variables to .env file

[Christopher Larson]

On Sun, Aug 30, 2015 at 2:14 PM, Ed Bartosh <ed.bartosh at linux.intel.com>
wrote:

> Write set of bitbake variables used by wic into
> build/tmp/sysroots/<machine>/imagedata/<image>.env
>
> List of variables is defined in WICVARS variable in
> meta/classes/image_types.bbclass.
>
> This is needed for wic to be able to get bitbake variables without
> running 'bitbake -e'.
>
> Signed-off-by: Ed Bartosh <ed.bartosh at linux.intel.com>
>

The function name (_write_env) sounds generic, as does the commit message,
and the filename, yet it relies on a variable which is WIC-specific. This
seems rather inconsistent to me, either this thing is for wic alone, or it
isn't, and the function name, file name, and variable name should reflect
that.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20150830/bd03f4b4/attachment-0002.html>