[OE-core] [PATCH v3 3/3] connman-conf: convert to an allarch package

Martin Jansa martin.jansa at gmail.com
Thu Dec 10 09:30:12 UTC 2015


On Thu, Dec 10, 2015 at 09:01:43AM +0000, Joshua Lock wrote:
> This recipe just installs some data files and a script and isn't machine or
> architecture specific. Even though it was designed to be used only for qemu
> machines there's no reason it can't be used elsewhere.

Sorry if I wasn't clear before.

I think it was better as machine specific.

We're using it in our layers to provide static configuration for connman
and that's often MACHINE specific (even the qemu config sets MAC which
you probably don't want to use the same across all MACHINEs built with
OE).

That's the reason why this recipe is in SIGGEN_EXCLUDERECIPES_ABISAFE.

This change also sets this static configuration for all builds, is
current wired.config really suitable for all devices? I don't think so.

> Signed-off-by: Joshua Lock <joshua.lock at collabora.co.uk>
> ---
>  meta/recipes-connectivity/connman/connman-conf.bb              | 10 ++++------
>  .../connman-conf/{qemuall => }/wired-connection.service        |  0
>  .../connman/connman-conf/{qemuall => }/wired-setup             |  0
>  .../connman/connman-conf/{qemuall => }/wired.config            |  0
>  4 files changed, 4 insertions(+), 6 deletions(-)
>  rename meta/recipes-connectivity/connman/connman-conf/{qemuall => }/wired-connection.service (100%)
>  rename meta/recipes-connectivity/connman/connman-conf/{qemuall => }/wired-setup (100%)
>  rename meta/recipes-connectivity/connman/connman-conf/{qemuall => }/wired.config (100%)
> 
> diff --git a/meta/recipes-connectivity/connman/connman-conf.bb b/meta/recipes-connectivity/connman/connman-conf.bb
> index bef9237..a8fdb8c 100644
> --- a/meta/recipes-connectivity/connman/connman-conf.bb
> +++ b/meta/recipes-connectivity/connman/connman-conf.bb
> @@ -4,18 +4,16 @@ network interface for a qemu machine."
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
>  
> -inherit systemd
> +inherit systemd allarch
>  
> -SRC_URI_append_qemuall = " file://wired.config \
> -                           file://wired-setup \
> -                           file://wired-connection.service \
> +SRC_URI = "file://wired.config \
> +           file://wired-setup \
> +           file://wired-connection.service \
>  "
>  PR = "r2"
>  
>  S = "${WORKDIR}"
>  
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> -
>  FILES_${PN} = "${localstatedir}/* ${datadir}/*"
>  
>  do_install() {
> diff --git a/meta/recipes-connectivity/connman/connman-conf/qemuall/wired-connection.service b/meta/recipes-connectivity/connman/connman-conf/wired-connection.service
> similarity index 100%
> rename from meta/recipes-connectivity/connman/connman-conf/qemuall/wired-connection.service
> rename to meta/recipes-connectivity/connman/connman-conf/wired-connection.service
> diff --git a/meta/recipes-connectivity/connman/connman-conf/qemuall/wired-setup b/meta/recipes-connectivity/connman/connman-conf/wired-setup
> similarity index 100%
> rename from meta/recipes-connectivity/connman/connman-conf/qemuall/wired-setup
> rename to meta/recipes-connectivity/connman/connman-conf/wired-setup
> diff --git a/meta/recipes-connectivity/connman/connman-conf/qemuall/wired.config b/meta/recipes-connectivity/connman/connman-conf/wired.config
> similarity index 100%
> rename from meta/recipes-connectivity/connman/connman-conf/qemuall/wired.config
> rename to meta/recipes-connectivity/connman/connman-conf/wired.config
> -- 
> 2.5.0
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20151210/45c10903/attachment-0002.sig>


More information about the Openembedded-core mailing list