[OE-core] [<OE-core][PATCH v2 1/4] weston-init: Handle Weston startup correctly.

[Tom Hochstein]

Hi Otavio,

Does the existence of /usr/lib/weston/xwayland.so give us what we want?

        if [ -f /usr/lib/weston/xwayland.so ]; then
            mkdir -p /tmp/.X11-unix
            OPTARGS="--modules=xwayland.so $OPTARGS"
        fi
        openvt $OPENVT_ARGS -- sh -c "weston-launch -- $OPTARGS > /var/log/weston.log 2>&1"

Tom

-----Original Message-----
From: Otavio Salvador [mailto:otavio.salvador at ossystems.com.br] 
Sent: Friday, December 18, 2015 10:50 AM
To: Hochstein Tom-R60874 <Tom.Hochstein at freescale.com>
Cc: Patches and discussions about the oe-core layer <openembedded-core at lists.openembedded.org>
Subject: Re: [OE-core] [<OE-core][PATCH v2 1/4] weston-init: Handle Weston startup correctly.

Hello Tom,

On Thu, Dec 17, 2015 at 8:04 PM, Tom Hochstein <tom.hochstein at freescale.com> wrote:
> Weston is started in different ways depending on the image 
> configuration and the runtime scenario. Refer to the weston man page 
> for more information.
>
> Signed-off-by: Tom Hochstein <tom.hochstein at freescale.com>

I think we are quite close to something which works for all supported use-cases. More below...

...
> @@ -13,6 +14,18 @@ do_install() {
>
>         install -d ${D}${systemd_system_unitdir}
>         install -m0644 ${WORKDIR}/weston.service 
> ${D}${systemd_system_unitdir}
> +
> +       install -d ${D}/${bindir}
> +       install -m755 ${WORKDIR}/weston-start ${D}/${bindir}
> +       if [ "${@bb.utils.contains('DISTRO_FEATURES', 'x11 wayland', 'xwayland', '', d)}" = "xwayland" ]; then
> +               weston_launch_setup="mkdir -p /tmp/.X11-unix"
> +               weston_launch_args="--modules=xwayland.so"
> +       else
> +               weston_launch_setup=""
> +               weston_launch_args=""
> +       fi
> +       sed -i "s#WESTON_LAUNCH_SETUP#${weston_launch_setup}#" ${D}/${bindir}/weston-start
> +       sed -i "s#WESTON_LAUNCH_ARGS#${weston_launch_args}#" 
> + ${D}/${bindir}/weston-start

We can do it at runtime and avoid using this hardcoded options?

One possibility is to check if XWayland is available. If it is, it can enable those options.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750