[OE-core] [PATCH 1/1] insane.bbclass: Added QA test for expanded ${D}

[Burton, Ross]

Hi Alejandro,

Looks good, but some small points:

On 11 December 2014 at 22:40, Alejandro Hernandez <
alejandro.hernandez at linux.intel.com> wrote:

> -            version-going-backwards \
> +            version-going-backwards expanded_d \
>
+QAPATHTEST[expanded_d] = "package_qa_check_expanded_d"
>

Rename this to expanded-d for consistency with the other symbols that use -
instead of _.


> +            # Variables are actually var_${PN}
>

No need to document idioms, remove this comment.


> +                        messages["expanded_d"] = "FILES should not
> contain the ${D} variable as it references the local build directory not
> the target filesystem, best solution is to remove the ${D} reference"
>

This doesn't name the package which makes it tricky to find in large builds.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20150107/a2afb355/attachment-0002.html>