[OE-core] in sysfsutils_2.1.0.bb, is 'S = "${WORKDIR}/sysfsutils-${PV}"' redundant?

Robert P. J. Day rpjday at crashcourse.ca
Tue Jan 13 13:14:30 UTC 2015


On Tue, 13 Jan 2015, Burton, Ross wrote:

>
> On 13 January 2015 at 12:57, Robert P. J. Day <rpjday at crashcourse.ca> wrote:
>       setting S that way in the recipe obviously doesn't do any
>       harm, but is it accurate to say that, at least in this case, it's
>       unnecessary?
>
>
> Correct.  A patch from the student is welcome. :)

  actually, there appears to be quite a lot of that scattered
throughout oe-core, so i'm not sure it's worth trying to clean it up
piecemeal as opposed to just doing it in one large patch. as i said, i
realize it doesn't hurt, but i'm a big fan of not having lines where
lines are unnecessary.

  i'll defer to the list ... is it worth tracking down all the recipes
that are doing that and just deleting that redundant line from them?
or is that just unnecessary code churn?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================


More information about the Openembedded-core mailing list