[OE-core] [PATCH] logrotate: fix missing acl and libselinux dependencies

[Anders Darander]

* Andre McCurdy <armccurdy at gmail.com> [150113 19:47]:
> On Tue, Jan 13, 2015 at 12:35 AM, Anders Darander <anders at chargestorm.se> wrote:
> > * Andre McCurdy <armccurdy at gmail.com> [150113 01:57]:
> >> +# TODO: logrotate 3.8.8 adds autotools/automake support, update recipe to use it.
> >> +# TODO: Document coreutils dependency. Why not RDEPENDS? Why not busybox?

> > It might well be worth adding autotools support right now.

> >>  DEPENDS="coreutils popt"

> >>  LIC_FILES_CHKSUM = "file://COPYING;md5=18810669f13b87348459e611d31ab760"
> >> @@ -21,6 +24,9 @@ PACKAGECONFIG ?= "\
> >>      ${@base_contains('DISTRO_FEATURES', 'selinux', 'selinux', '', d)} \
> >>  "

> >> +PACKAGECONFIG[acl] = ",,acl"
> >> +PACKAGECONFIG[selinux] = ",,libselinux"

> > The problem with these two lines, are that you're not explicitly
> > enabling and disabling those two features; thus our builds won't be
> > deterministic.

> Currently the configure task for logrotate is a no-op, so the normal
> way of constructing a configure command line via PACKAGECONFIG doesn't
> work.

Yep, that's why I suggested moving to autotools etc...

> We do however need to include acl and libselinux in DEPENDS if enabled
> - which wasn't happening before and is what the patch attempts to fix,

> There are no floating dependencies since acl and selinux are enabled
> explicitly during compile, by options passed on the make command line
> via EXTRA_OEMAKE.

Ok, I missed that one as it was outside of the patch.

Then I presume that there's no need to disable those features when
they're not enabled? Right? If so, it should be fine for the moment.

Cheers,
Anders
-- 
Anders Darander
ChargeStorm AB / eStorm AB