[OE-core] [PATCH] base-files/profile: change EDITOR to not be busybox specific

[Dan McGregor]

On 21 January 2015 at 12:25, Paul Gortmaker
<paul.gortmaker at windriver.com> wrote:
> Setting "EDITOR=/bin/vi" breaks on non-busybox systems, as
> vim will populate /usr/bin/vi instead, and you get stuff like:
>
>   op3:~/poky/meta-builder$ git commit -s
>   error: cannot run /bin/vi: No such file or directory
>   error: unable to start editor '/bin/vi'
>   Please supply the message using either -m or -F option.
>   op3:~/poky/meta-builder$ which vi
>   /usr/bin/vi
>   op3:~/poky/meta-builder$
>
> Since we've already specified a proper path above in the profile,
> we've no need to call out where in the path vi lives, and hence
> this will work with busybox and a full vim install w/o busybox.
>
> Signed-off-by: Paul Gortmaker <paul.gortmaker at windriver.com>
> ---
>  meta/recipes-core/base-files/base-files/profile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/base-files/base-files/profile b/meta/recipes-core/base-files/base-files/profile
> index 88ab8d877b0d..53c2680409dd 100644
> --- a/meta/recipes-core/base-files/base-files/profile
> +++ b/meta/recipes-core/base-files/base-files/profile
> @@ -2,7 +2,7 @@
>  # and Bourne compatible shells (bash(1), ksh(1), ash(1), ...).
>
>  PATH="/usr/local/bin:/usr/bin:/bin"
> -EDITOR="/bin/vi"                       # needed for packages like cron
> +EDITOR="vi"                    # needed for packages like cron, git-commit
>  test -z "$TERM" && TERM="vt100"        # Basic terminal capab. For screen etc.
>
>  if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; then

While I agree with this change, arguably busybox should also be
changed. Everywhere I look "vi" lives in /usr/bin. FreeBSD, NetBSD,
Ubuntu, and Slackware all seem to put vi in /usr/bin.

The same is true of getopt.

What are other people's thoughs?