[OE-core] [PATCH v3 2/6] adwaita-icon-theme: Add new icon theme for GTK+

Jussi Kukkonen jussi.kukkonen at intel.com
Thu Jul 2 08:15:57 UTC 2015


On 30 June 2015 at 18:47, Burton, Ross <ross.burton at intel.com> wrote:
> On 16 June 2015 at 15:22, Jussi Kukkonen <jussi.kukkonen at intel.com> wrote:
>> +inherit autotools pkgconfig gettext gtk-icon-cache
>
> Does this recipe build with allarch?

Not with my autotools fu... adwaita has a couple of strings they want
translated so they use intltool. intltool.m4 decides to do a compile
test (because of a Solaris corner case) and this naturally leads to a
configure failure on allarch. Search for "Set DATADIRNAME correctly"
in intltool.m4 if you want to see it.

Hints on how to fix that are welcome -- allarch would be helpful as
install really does take quite a while.

> Would it be sensible to split out the high-resolution icons (the 256x256)
> into a sub-package so systems that don't have very high resolution screens
> don't need to ship them?  I guess it comes down to how big they are.

Agreed, based on the numbers in your other email I'll add a
"adwaita-icon-theme-hires".

>> +RRECOMMENDS_${PN} += "librsvg-gtk"
>
> If there's no SVG files in the theme, we don't need to depend on the SVG
> loader.

Oh yes, my bad. I didn't remove it because I was thinking of possible
other themes that get installed and might include svg icons... but
that's not something this recipe should take care of.

Jussi



More information about the Openembedded-core mailing list