[OE-core] [PATCH][resend] perl: fix build failure if building dir has the "blib" string

[Jens Rehsack]

> Am 10.07.2015 um 11:28 schrieb Rongqing Li <rongqing.li at windriver.com>:
> 
> 
> 
> On 2015年07月10日 17:09, Jens Rehsack wrote:
>> Hi,
>> 
>> When build dir includes contain blib, there is an error which should be solved first.
>> 
>> Can you please give an example where this condition is true?
>> And maybe refer where you reported it upstream?
>> 
> 
> the below commands can trigger this bug; under Poky repo:
> 
> #source oe-init-build-env blib;
> #bitbake perl

Simply add a comment that blib as build-env name is not supported as long as no
comment from PathTools maintainers agree on the patch. I rate your patch as dangerous
for common perl module building...

I agree that PathTools should handle @INC parts containing blib somewhere, but
your patch results in any build environment of any MakeMaker base module might be
broken.

If you tell me the RT ticket number where you reported the issue upstream and
send your patch for review, I will join and argue for fixing the issue (even when
I think the patch needs review).

> or work on source code:
> 
> #mkdir blib
> #cd blib
> #unxz perl-5.22.0.tar.xz
> #tar -xvf perl-5.22.0.tar
> #cd perl-5.22.0
> #./Configure -des -Dprefix=./
> #make

Don't do that - neither for PathTools nor for any other perl module.

Cheers,
Jens

> -Roy
> 
> 
>> Best regards,
>> Jens
>> 
>>> Am 10.07.2015 um 10:54 schrieb rongqing.li at windriver.com:
>>> 
>>> From: Wenzong Fan <wenzong.fan at windriver.com>
>>> 
>>> If build dir includes the string "blib", filter it out from @INC may empty
>>> the @INC and cause build errors like:
>>> 
>>>  Can't locate ExtUtils/MakeMaker.pm in @INC \
>>>  (you may need to install the ExtUtils::MakeMaker module) \
>>>  (@INC contains: .) at Makefile.PL
>>> 
>>> Signed-off-by: Roy Li <rongqing.li at windriver.com>
>>> Signed-off-by: Wenzong Fan <wenzong.fan at windriver.com>
>>> ---
>>> meta/recipes-devtools/perl/perl-native_5.22.0.bb   |  1 +
>>> ...-PathTools-don-t-filter-out-blib-from-INC.patch | 33 ++++++++++++++++++++++
>>> meta/recipes-devtools/perl/perl_5.22.0.bb          |  1 +
>>> 3 files changed, 35 insertions(+)
>>> create mode 100644 meta/recipes-devtools/perl/perl/perl-PathTools-don-t-filter-out-blib-from-INC.patch
>>> 
>>> diff --git a/meta/recipes-devtools/perl/perl-native_5.22.0.bb b/meta/recipes-devtools/perl/perl-native_5.22.0.bb
>>> index dbcf2a6..a9a1cab 100644
>>> --- a/meta/recipes-devtools/perl/perl-native_5.22.0.bb
>>> +++ b/meta/recipes-devtools/perl/perl-native_5.22.0.bb
>>> @@ -8,6 +8,7 @@ SRC_URI += "\
>>>            file://MM_Unix.pm.patch \
>>>            file://debian/errno_ver.diff \
>>>            file://dynaloaderhack.patch \
>>> +           file://perl-PathTools-don-t-filter-out-blib-from-INC.patch \
>>>           "
>>> 
>>> SRC_URI[md5sum] = "ff0f09b17de426eff323426cb140ee79"
>>> diff --git a/meta/recipes-devtools/perl/perl/perl-PathTools-don-t-filter-out-blib-from-INC.patch b/meta/recipes-devtools/perl/perl/perl-PathTools-don-t-filter-out-blib-from-INC.patch
>>> new file mode 100644
>>> index 0000000..7dd9041
>>> --- /dev/null
>>> +++ b/meta/recipes-devtools/perl/perl/perl-PathTools-don-t-filter-out-blib-from-INC.patch
>>> @@ -0,0 +1,33 @@
>>> +From 90c252cecc38aed5d5faedb30485dd6eee2e54eb Mon Sep 17 00:00:00 2001
>>> +From: Wenzong Fan <wenzong.fan at windriver.com>
>>> +Date: Wed, 11 Feb 2015 15:14:40 +0800
>>> +Subject: [PATCH] perl / PathTools: don't filter out blib from @INC
>>> +
>>> +If $TOPDIR includes the string "blib", filter it out from @INC may empty
>>> +the @INC and cause build errors like:
>>> +
>>> +  Can't locate ExtUtils/MakeMaker.pm in @INC \
>>> +  (you may need to install the ExtUtils::MakeMaker module) \
>>> +  (@INC contains: .) at Makefile.PL
>>> +
>>> +Upstream-Status: Pending
>>> +
>>> +Signed-off-by: Wenzong Fan <wenzong.fan at windriver.com>
>>> +---
>>> + dist/PathTools/Makefile.PL | 3 ---
>>> + 1 file changed, 3 deletions(-)
>>> +
>>> +diff --git a/dist/PathTools/Makefile.PL b/dist/PathTools/Makefile.PL
>>> +index 1b21de4..f562cb2 100644
>>> +--- a/dist/PathTools/Makefile.PL
>>> ++++ b/dist/PathTools/Makefile.PL
>>> +@@ -1,6 +1,3 @@
>>> +-
>>> +-BEGIN { @INC = grep {!/blib/} @INC }
>>> +-
>>> + require 5.005;
>>> + use ExtUtils::MakeMaker;
>>> + WriteMakefile
>>> +--
>>> +1.9.1
>>> +
>>> diff --git a/meta/recipes-devtools/perl/perl_5.22.0.bb b/meta/recipes-devtools/perl/perl_5.22.0.bb
>>> index 050a98c..7f78998 100644
>>> --- a/meta/recipes-devtools/perl/perl_5.22.0.bb
>>> +++ b/meta/recipes-devtools/perl/perl_5.22.0.bb
>>> @@ -61,6 +61,7 @@ SRC_URI += " \
>>>         file://t-run-switches.t-perl5-perl.patch \
>>>         file://ext-ODBM_File-hints-linux.pl-link-libgdbm_compat.patch \
>>>         file://ext-ODBM_File-t-odbm.t-fix-the-path-of-dbmt_common.p.patch \
>>> +        file://perl-PathTools-don-t-filter-out-blib-from-INC.patch \
>>> "
>>> 
>>> # Fix test case issues
>>> --
>>> 1.9.1
>>> 
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core at lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> 
> 
> -- 
> Best Reagrds,
> Roy | RongQing Li

-- 
Jens Rehsack - rehsack at gmail.com