[OE-core] [PATCH 0/4] Fixes for shell message changes (OE-Core side)

Paul Eggleton paul.eggleton at linux.intel.com
Tue Jul 14 14:56:52 UTC 2015


Unfortunately the shell message changes caused a few minor regressions;
this is a perfect example of a situation where what seems like a simple
and logical change can have unintended consequences that you'll miss if
you're not careful. More testing all round would probably be advisable
in future. Having said that, it has had the effect of highlighting
something that we need to be mindful of in future - don't call bbfatal()
where you expect the rest of the error log to be printed - use die() or
bbfatal_log() for that, or alternatively make your message meaningful
enough that you don't need the log.

NOTE: the fix for die() and bbfatal_log() requires the BitBake change
that implements bbfatal_log internally which has just sent to the
bitbake-devel list. Having said that, logging.bbclass now works as it
used to for older BitBake versions that didn't have the message support
at all.


The following changes since commit 6be698b7270f73f40d38713ecf13f12aec0ced61:

  dpkg: Fix for Fedora22 and new versions of tar (2015-07-13 13:46:45 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib paule/oecore-shell-logging-fixes
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/oecore-shell-logging-fixes

Paul Eggleton (4):
  classes/useradd: don't read bbnote/bbwarn/bbfatal values
  classes/base: fix die() to print the full log
  Use die() or bbfatal_log() where the log should definitely be printed
  classes/logging: allow shell message functions to work in devshell

 meta/classes/autotools.bbclass              |  4 +--
 meta/classes/base.bbclass                   |  2 +-
 meta/classes/kernel-yocto.bbclass           | 16 +++++-----
 meta/classes/logging.bbclass                | 48 +++++++++++++++++++++++++----
 meta/classes/scons.bbclass                  |  4 +--
 meta/classes/useradd.bbclass                |  6 ++--
 meta/recipes-extended/groff/groff_1.22.3.bb |  2 +-
 7 files changed, 59 insertions(+), 23 deletions(-)

-- 
2.1.0




More information about the Openembedded-core mailing list