[OE-core] [PATCH v2] oeqa/buildoptions.py: automate test case 929: check for correct GPL licenses

Paul Eggleton paul.eggleton at linux.intel.com
Thu Jul 23 13:40:00 UTC 2015


Hi Costin,

On Thursday 23 July 2015 16:40:44 Costin Constantin wrote:
> Signed-off-by: Costin Constantin <costin.c.constantin at intel.com>
> ---
>  meta/lib/oeqa/selftest/buildoptions.py | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/meta/lib/oeqa/selftest/buildoptions.py
> b/meta/lib/oeqa/selftest/buildoptions.py index e79be9e..ab009f2 100644
> --- a/meta/lib/oeqa/selftest/buildoptions.py
> +++ b/meta/lib/oeqa/selftest/buildoptions.py
> @@ -132,6 +132,36 @@ class BuildImagesTest(oeSelfTest):
>          res = bitbake("core-image-directfb", ignore_status=True)
>          self.assertEqual(res.status, 0, "\ncoreimagedirectfb failed to
> build. Please check logs for further details.\nbitbake output %s" %
> res.output)
>
> 
> +    @testcase(929)
> +    def test_gpl_licenses(self):
> +        """
> +        Test for checking that correct GPL licenses are used when
> explicitly required. 
> +        """
> +        self.add_command_to_tearDown('cleanup-workdir')

I really don't think we should be calling cleanup-workdir here. If we have 
specific things to bitbake -c clean, by all means do that - but cleanup-workdir 
goes through and deletes everything that's not current, which is excessive for 
this one test.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



More information about the Openembedded-core mailing list