[OE-core] [PATCH] u-boot-mkimage: fix a building failure on OpenSus

Burton, Ross ross.burton at intel.com
Tue Jul 28 11:47:28 UTC 2015


On 28 July 2015 at 03:00, <rongqing.li at windriver.com> wrote:

> +config.mk will be included only if auto.conf is newer than .config
> +but in some system, the HPET is not enabled, the smallest unit of
> +time is second, and can not decise which file is newer, even if
> +the correct dependency has been created.
> +
> +The below shows unit of time:
> +
> +under SUSE Linux Enterprise Desktop 11 SP2  (i586):
> +    $ls --full-time include/config/auto.conf .config
> +    2015-07-27 03:46:20.000000000 -0400 .config
> +    2015-07-27 03:46:20.000000000 -0400 include/config/auto.conf
> +    $
> +
> +under Ubuntu 14.04 LTS:
> +    $ ls --full-time include/config/auto.conf .config
> +    2015-07-27 13:40:14.008703027 +0800 .config
> +    2015-07-27 13:40:15.020703054 +0800 include/config/auto.conf
> +    $
> +
> +The rule of including config.mk in Makefile as below
> +    autoconf_is_current := $(if $(wildcard $(KCONFIG_CONFIG)),$(shell
> find . \
> +                    -path ./include/config/auto.conf -newer
> $(KCONFIG_CONFIG)))
> +    ifneq ($(autoconf_is_current),)
> +    include $(srctree)/config.mk
> +    include $(srctree)/arch/$(ARCH)/Makefile
> +    endif
> +
> +The compilation will be failed if config.mk is not included
> +so delay 1 second to create auto.conf after creating of .config
>

Adding a sleep seems pretty ugly, wouldn't a neater fix be to change the
logic so that instead of the test being "is newer" you use "is not older",
to handle identical timestamps as being current.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20150728/5bce7e41/attachment-0002.html>


More information about the Openembedded-core mailing list