[OE-core] [PATCH] watchdog: kill update-rc.d when not using sysvinit

[Rehman, Abdur]

watchdog_5.14.bb does not inherit systemd, and so INHIBIT_UPDATERCD_BBCLASS does
not get set.

While trying to build watchdog with systemd in DISTRO_FEATURES but not sysvinit,
following warning is observed:
    WARNING: QA Issue: watchdog rdepends on initscripts-functions, but it isn't
    a build dependency? [build-deps]

Since sysvinit is not in DISTRO_FEATURES and INHIBIT_UPDATERCD_BBCLASS is not
set, the logic in update-rc.d.bbclass goes on to add an rdep for watchdog on
initscripts-functions, inside update_rcd_package(). And this results in the
QA warning.

The patch sets INHIBIT_UPDATERCD_BBCLASS in the recipe to force
populate_packages_updatercd() not to proceed with update_rcd_package().

Kindly suggest if there is a better way to tackle this issue.

Abdur Rehman
________________________________
From: Burton, Ross [ross.burton at intel.com]
Sent: Wednesday, July 29, 2015 1:46 AM
To: Rehman, Abdur
Cc: OE-core; Larson, Chris
Subject: Re: [OE-core] [PATCH] watchdog: kill update-rc.d when not using sysvinit


On 28 July 2015 at 18:11, Abdur Rehman <abdur_rehman at mentor.com<mailto:abdur_rehman at mentor.com>> wrote:
+python () {
+    if not bb.utils.contains('DISTRO_FEATURES', 'sysvinit', True, False, d):
+        d.setVar("INHIBIT_UPDATERCD_BBCLASS", "1")
+}

Isn't this what the update-rcd logic does already:

    # Check that this class isn't being inhibited (generally, by
    # systemd.bbclass) before doing any work.
    if bb.utils.contains('DISTRO_FEATURES', 'sysvinit', True, False, d) or \
       not d.getVar("INHIBIT_UPDATERCD_BBCLASS", True):

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20150729/d8765a55/attachment-0002.html>