[OE-core] [PATCH] curl: Modify PACKAGECONFIG to enable openssl

[Anders Darander]

* Li xin <lixin.fnst at cn.fujitsu.com> [150612 05:41]:

> Enabled openssl defalutly to use https, just like Ubuntu and Red Hat do.

> Signed-off-by: Li Xin <lixin.fnst at cn.fujitsu.com>
> ---

> -PACKAGECONFIG ??= "${@bb.utils.contains("DISTRO_FEATURES", "ipv6", "ipv6", "", d)} gnutls zlib"
> +PACKAGECONFIG ??= "${@bb.utils.contains("DISTRO_FEATURES", "ipv6", "ipv6", "", d)} ssl zlib"

I think you need to motivate why you're changing from gnutls to ssl
(openssl) here.

Not that I'm personally against it. I've occasionally done the same
thing locally. But this is a change of the defaults, and the default
dependencies. Thus, it needs to have a good motivation.

>  PACKAGECONFIG_class-native = "ipv6 ssl zlib"
>  PACKAGECONFIG_class-nativesdk = "ipv6 ssl zlib"

> @@ -36,6 +36,7 @@ EXTRA_OECONF = "--without-libidn \
>                  --disable-ldap \
>                  --disable-ldaps \
>                  --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt \
> +                --with-libssh2 \

NACK.

We have a PACKAGECONFIG för libssh2, which defaults to off. Do /not/
enable it directly in EXTRA_OECONF. This will break builds (at least
the determinism of builds).

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB / eStorm AB