[OE-core] [PATCH] [fido] binutils: fix native builds when host has gcc5

[Khem Raj]

On Thu, Jun 11, 2015 at 1:27 AM, Martin Stolpe <martinstolpe at gmail.com> wrote:
> Yes, it would be better to fix these warnings. But on the other hand
> this patch would just restore the previous behavior. So as a long term
> solution I agree with you that these warnings should be fixed but why
> not use a workaround until the problems are fixed?

who will fix it ? you have a problem at hand you are tackling try to
see if it can be dealt with best possible way.

 I wouldn't dare to
> try to fix these warnings on my own as these are just my first steps
> with Yocto and programming and I wouldn't be confident that my changes
> would be correct.

Even if this workaround has to be persisted then just contain the
workaround to native variants, and only for fido, it should not go
into master at all.

>
> 2015-06-10 17:42 GMT+02:00 Khem Raj <raj.khem at gmail.com>:
>> On Wed, Jun 10, 2015 at 10:26 AM, Martin Stolpe <martinstolpe at gmail.com> wrote:
>>> Problem is that when building binutils using GCC >=5.0
>>> warnings will be treated as errors which will cause
>>> the build to fail.
>>>
>>> Signed-off-by: Martin Stolpe <martin.stolpe at gmail.com>
>>> ---
>>>  meta/recipes-devtools/binutils/binutils_2.24.bb | 5 ++++-
>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-devtools/binutils/binutils_2.24.bb b/meta/recipes-devtools/binutils/binutils_2.24.bb
>>> index 738aaee..bc34a14 100644
>>> --- a/meta/recipes-devtools/binutils/binutils_2.24.bb
>>> +++ b/meta/recipes-devtools/binutils/binutils_2.24.bb
>>> @@ -7,12 +7,15 @@ EXTRA_OECONF += "--with-sysroot=/ \
>>>                  --enable-install-libbfd \
>>>                  --enable-install-libiberty \
>>>                  --enable-shared \
>>> +                --disable-werror \
>>>                  "
>>>
>>>  EXTRA_OECONF_class-native = "--enable-targets=all \
>>>                               --enable-64-bit-bfd \
>>>                               --enable-install-libiberty \
>>> -                             --enable-install-libbfd"
>>> +                             --enable-install-libbfd \
>>> +                             --disable-werror \
>>> +                             "
>>
>> lowering the guards is not the right approach. I understand you want
>> to compile fido with distros that are released after fido.
>> but better would be to backport relevant fixed into component itself.
>>
>>>
>>>  do_install_class-native () {
>>>         autotools_do_install
>>> --
>>> 2.4.2
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core at lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core