[OE-core] [PATCH v2 6/6] midori: Depend on Adwaita, not gnome-icon-theme

[Jussi Kukkonen]

On 12 June 2015 at 18:25, Alexander Kanavin
<alexander.kanavin at linux.intel.com> wrote:
> On 06/12/2015 04:11 PM, Jussi Kukkonen wrote:
>
>> -RRECOMMENDS_${PN} += "glib-networking ca-certificates gnome-icon-theme"
>> +RRECOMMENDS_${PN} += "glib-networking ca-certificates adwaita-icon-theme"
>
> This should probably be moved to gtk+ recipes or gnome class; if most(all?)
> gtk+ applications need those icons, then they shouldn't have to list them in
> their own recipes.

Thanks for the reminder, I was going to bring this up:

GTK+ does not have fallback icons included and uses symbolic icons in
many places (and the hicolor icon set does not include symbolic
icons). This means that without symbolic icons installed many GTK+
applications will look bad with placeholder icons even in stock
widgets.

So gtk+3 should probably RRECOMMEND something that provides a symbolic
theme -- currently the only option is Adwaita. If the size increase
(of an image that contains GTK) is seen as prohibitive I could
separate the symbolic icons and the normal icons: that way gtk+3 could
recommend just the symbolic theme which would 'only' be 11MB
additional size.

Now that I think about it, I guess dividing the icons into those
separate packages makes sense anyway. I'm going to do that in V3 of
this patch set but would appreciate advice on what to do with the
dependency/recommendation question.

Jussi