[OE-core] [wic][PATCH 04/20] wic: Refactor getting bitbake variables

Christopher Larson clarson at kergoth.com
Mon Jun 29 21:48:30 UTC 2015


On Mon, Jun 29, 2015 at 12:10 PM, Ed Bartosh <ed.bartosh at linux.intel.com>
wrote:

> +    global _BITBAKE_VARS
> +
> +    if image not in _BITBAKE_VARS:
>

In general, I’d suggest using a cache class/object rather than globals,
similar to how it’s handled in bb.checksum, or a transparent LRU. Whenever
a cache is involved, it’s best to consider what its lifetime is.
Admittedly, wic isn’t long-running, but best not to get into bad habits.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20150629/68deae70/attachment-0002.html>


More information about the Openembedded-core mailing list