[OE-core] [OE-core Yocto PATCH 3/4] bootimg: Skip build iso image for aarch64

[Naresh Bhat]

On 4 March 2015 at 12:56, Bernhard Reutner-Fischer
<rep.dot.nop at gmail.com> wrote:
> On March 4, 2015 8:15:15 AM GMT+01:00, Naresh Bhat <naresh.bhat at linaro.org> wrote:
>>On 3 March 2015 at 23:27, Bernhard Reutner-Fischer
>><rep.dot.nop at gmail.com> wrote:
>>> On 3 March 2015 at 16:46, Naresh Bhat <naresh.bhat at linaro.org> wrote:
>>>> Build iso image required syslinux package.  We have already skip the
>>syslinux
>>>> package.  Hence just skip the iso image build too.
>>>>
>>>> Signed-off-by: Naresh Bhat <naresh.bhat at linaro.org>
>>>> Reviewed-by: Matt Fleming <matt.fleming at intel.com>
>>>> ---
>>>>  meta/classes/bootimg.bbclass |    6 +++++-
>>>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/classes/bootimg.bbclass
>>b/meta/classes/bootimg.bbclass
>>>> index a8e0c19..2edba3a 100644
>>>> --- a/meta/classes/bootimg.bbclass
>>>> +++ b/meta/classes/bootimg.bbclass
>>>> @@ -266,7 +266,11 @@ python do_bootimg() {
>>>>      if d.getVar("EFI", True) == "1":
>>>>          bb.build.exec_func('build_efi_cfg', d)
>>>>      bb.build.exec_func('build_hddimg', d)
>>>> -    bb.build.exec_func('build_iso', d)
>>>> +
>>>> +    if [ "${TARGET_ARCH}" == "aarch64" ]:
>>>> +             return
>>>
>>> erm is this shell-code or python-code?
>>>
>>> For the former there is no "==" operator for POSIX-compliant test(1)
>>> implementations, for the latter the "[" looks suspicious.
>>>
>>> What am i missing?
>>> thanks,
>>
>>Ah my mistake, Probably I could have implemented as below
>>
>>if d.getVar('TARGET_ARCH', True) == "aarch64":
>>               return
>>
>>Does it make sense ?
>
> At least the parser should grok it.
> The change itself does not make sense to me either way.
I did this change because it does not make any sense to build the ISO
image for aarch64 architecture.  The HDD image should be sufficient.
Correct me if I am wrong.  I find a dependency of syslinux package to
build ISO image (isolinux.bin).  I have skipped the syslinux package
dependency @luvOS distribution.  The syslinux package contains lot of
x86 assembly code. That's the reason I just want to skip the ISO image
build for aarch64 architecture.

I will try to explain as much as possible in my next series patch
>
> Thanks,
>>
>>>> +    else:
>>>> +            bb.build.exec_func('build_iso', d)
>>>>  }
>>>>
>>>>  IMAGE_TYPEDEP_iso = "ext3"
>
>