[OE-core] [PATCH] openssl: add a vardeps for configure on libdir

[Mark Asselstine]

On March 25, 2015 13:35:46 Christopher Larson wrote:
> On Wed, Mar 25, 2015 at 12:28 PM, Mark Asselstine <
> 
> mark.asselstine at windriver.com> wrote:
> > My first attempt I had tried "libdir" and it doesn't seem to have the
> > needed
> > effect. I was hesitant to use other variables (such as those that libdir
> > is
> > derived from) as that would fork how -native and target builds would be
> > handled. I had found other instances (meta/classes/package.bbclass) that
> > seemed to use vardeps on expanded variables. At any rate I will circle
> > back,
> > your comment was not entirely unexpected, just the push that is needed for
> > me
> > to look more closely. I will follow up in a bit.
> 
> package.bbclass has variables containing / functions returning lists of
> variable names. libdir isn't a list of variable names, it's a path.

Agreed. And this is why I was going back to look at it.

> 
> > Second, if libdir is used in do_configure, then changing
> > 
> > > it will already cause do_configure to be re-run, as bitbake tracks
> > 
> > variable
> > 
> > > references. Only references which can't be tracked by bitbake need to be
> > > listed explicitly.
> > 
> > The observed behavior definitely supports the view that this is a case
> > where
> > it can't be tracked. It is definitely a different usage than you would
> > find
> > normally.
> > 
> > do_configure () {
> > ...
> > 
> >     perl ./Configure ${EXTRA_OECONF} shared --prefix=$useprefix \
> >     
> >        --openssldir=${libdir}/ssl --libdir=`basename ${libdir}` $target
> > 
> > }
> 
> Nope, this is exactly what bitbake knows how to track, a standard variable
> reference; ${libdir}. It knows that do_configure uses libdir already. It's
> only when the variable name is determined programmatically at runtime in
> python that bitbake isn't able to track the reference (e.g. d.getVar(foo +
> "bar", True)).

Using 'bitbake-dumpsig' I can confirm that 'libdir' is listed in the 
do_configure 'Task dependencies' in the sstate. This explains why with or 
without

do_configure[vardeps] += "libdir"


the outcome didn't change, the change was essentially a nop. The variable is 
definitely at play during configure, as mentioned in my commit log it is used as 
a hard coded abs path. For instance it is substituted in the package's 
crypto/opensslconf.h file.

When the sstate is reused in a different location configure needs to be rerun. 
Similarly if libdir for the target is modified it needs to rerun configure.

Any ideas why/how libdir is listed as a task dependency yet even with it 
changing the task is being rerun?

I will keep investigating.

Mark