[OE-core] [PATCH 3/4] systemd: split modules into packages

[Otavio Salvador]

On Thu, Mar 26, 2015 at 5:29 AM, Anders Darander <anders at chargestorm.se> wrote:
> * Bruno Bottazzini <bruno.bottazzini at intel.com> [150325 22:50]:
>
>> if one wants to launch a simple deamon, most modules are not
>> required.
>> He will be able to save space and exclude unwanted packages
>> from the final image.
>
> I like this, though I've got a few questions that I just noticed.
>
>> -PACKAGECONFIG ??= "xz ldconfig \
>> +PACKAGECONFIG ??= " \
>> +                   gcrypt \
>> +                   kmod \
>> +                   ldconfig \
>> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'blkid', 'blkid', '', d)} \
>> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'efi', 'efi', '', d)} \
>> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'lz4', 'lz4', '', d)} \
>> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'xz', 'xz', '', d)} \
>> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'libidn', 'libidn', '', d)} \
>> +                   ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)} \
>>                     ${@bb.utils.contains('DISTRO_FEATURES', 'pam', 'pam', '', d)} \
>>                     ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'xkbcommon', '', d)}"
>
> It might be worth noting that xz has gone from being explicitly enabled,
> to depend on a DISTRO_FEATURES.

Agreed and we shouldn't explode the number of possible dsitro
features. I'd also prefer if xz were kept enable by default so we
don't make a behavior change under the hood.

...
>>  PACKAGECONFIG[resolved] = "--enable-resolved,--disable-resolved"
>> -PACKAGECONFIG[networkd] = "--enable-networkd,--disable-networkd"
>
> Why do you remove networkd as a PACKAGECONFIG?

If there is a real reason for this, it must be recorded in commit log as well.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750