[OE-core] [PATCH 1/2] linux-yocto: add kern-tools-native to kernel_metadata depends

[Bruce Ashfield]

On Fri, Mar 27, 2015 at 11:21 AM, Ross Burton <ross.burton at intel.com> wrote:
> The autobuilder failed like this:
>
>   temp/run.do_kernel_metadata.25242: line 165: createme: command not found
>
> createme is provided by kern-tools-native.  do_patch has a dependency on
> kern-tools-native, but do_kernel_metadata runs before do_patch.  So move the
> dependency from do_patch to do_kernel_metadata, moving the statement from the
> .inc to the class so it's alongside the task definition.

Agreed. I've meant to do this cleanup myself a few times .. and then
get sidetracked.

If the depends had been beside the task definition in the .inc, I
would have realized
that I needed to tweak it at the same time .. so this is much better.

Acked-by: Bruce Ashfield <bruce.ashfield at windriver.com>

>
> [ YOCTO #7531 ]
>
> Signed-off-by: Ross Burton <ross.burton at intel.com>
> ---
>  meta/classes/kernel-yocto.bbclass         |    1 +
>  meta/recipes-kernel/linux/linux-yocto.inc |    2 --
>  2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
> index 14551a2..a1fbb51 100644
> --- a/meta/classes/kernel-yocto.bbclass
> +++ b/meta/classes/kernel-yocto.bbclass
> @@ -261,6 +261,7 @@ do_kernel_checkout[dirs] = "${S}"
>
>  addtask kernel_checkout before do_patch after do_unpack
>  addtask kernel_metadata after do_validate_branches before do_patch
> +do_kernel_metadata[depends] = "kern-tools-native:do_populate_sysroot"
>
>  do_kernel_configme[dirs] += "${S} ${B}"
>  do_kernel_configme() {
> diff --git a/meta/recipes-kernel/linux/linux-yocto.inc b/meta/recipes-kernel/linux/linux-yocto.inc
> index c62f8ca..5b69a49 100644
> --- a/meta/recipes-kernel/linux/linux-yocto.inc
> +++ b/meta/recipes-kernel/linux/linux-yocto.inc
> @@ -32,8 +32,6 @@ KCONF_BSP_AUDIT_LEVEL ?= "0"
>
>  LINUX_VERSION_EXTENSION ?= "-yocto-${LINUX_KERNEL_TYPE}"
>
> -do_patch[depends] = "kern-tools-native:do_populate_sysroot"
> -
>  addtask kernel_configme before do_configure after do_patch
>
>  # Pick up shared functions
> --
> 1.7.10.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"