[OE-core] [PATCH] dpkg-native: Avoid 'file changed' errors from tar

Richard Purdie richard.purdie at linuxfoundation.org
Mon Mar 30 14:58:43 UTC 2015


On Mon, 2015-03-30 at 10:52 -0300, Otavio Salvador wrote:
> On Sat, Mar 28, 2015 at 5:50 AM, Richard Purdie
> <richard.purdie at linuxfoundation.org> wrote:
> > See the patch header for details. Hardlink count duing do_package_write_deb
> > can change causing dpkg-deb failures. We don't care about this error
> > case so avoid it by checking the tar exit code.
> >
> > [YOCTO #7529]
> >
> > Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> 
> Please don't ask someone to see the patch header for information. This
> should be in the commit log and not necessarily read the diff to find
> this information.
> 
> Please send a v2 adding this information in the commit log.

Just referring someone to the patch header would be incorrect and I
agree a summary of the problem is needed. The commit message in question
does have this. I don't see the point of cut and pasting all the details
from the header into the commit message. The correct place for the
details in a situation like this is the patch header so that someone has
full details of the patch without having to look at the repo history.

Cheers,

Richard





More information about the Openembedded-core mailing list