[OE-core] [PATCH] dpkg-native: Avoid 'file changed' errors from tar

[Otavio Salvador]

On Mon, Mar 30, 2015 at 1:02 PM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Mon, 2015-03-30 at 12:02 -0300, Otavio Salvador wrote:
>> +When running do_package_write_deb, we have trees of symlinked files
>> +such as the dbg source files in ${PN}-dbg. If something makes another
>> +copy of one of those files (or deletes one), the number of links a file
>> +has changes and tar can notice this, e.g.:
>> +
>> +| DEBUG: Executing python function do_package_deb
>> +| dpkg-deb: building package `sed-ptest' in
>> `/media/build1/poky/build/tmp/work/i586-poky-linux/sed/4.2.2-r0/deploy-debs/i586/sed-ptest_4.2.2-r0.3_i386.deb'.
>> +| tar: ./usr/lib/sed/ptest/testsuite/tst-regex2: file changed as we read it
>> +| dpkg-deb: error: subprocess tar -cf returned error exit status 1
>> +
>> +Tar returns an error of 1 when files 'change' and other errors codes
>> +in other error cases. We tweak dpkg-deb here so that it ignores an exit
>> +code of 1 from tar. The files don't really change (and we have locking in
>> +place to avoid that kind of issue).
>>
>> This is exactly what I would expect for the long commit log. Sorry but
>> I strongly disagrese with you as the commit log in the patch does
>> connect with the short log so I still believe the commit log could be
>> improved.
>
> Well, I strong disagree with that, I don't believe it makes sense to cut
> and paste the same information into both places, sorry.

I disagree someone should go into a patch header to understand it.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750