[OE-core] [PATCH 1/3] distrodata.bbclass/distro_check.py: Fix splits

[Burton, Ross]

On 31 March 2015 at 23:03, Burton, Ross <ross.burton at intel.com> wrote:

>
> On 31 March 2015 at 21:11, Beth Flanagan <elizabeth.flanagan at intel.com>
> wrote:
>
>> +        if pnstripped.find("-native") != -1:
>>
>
> Shouldn't this be .endswith() or .startswith() to prevent false-positives?
>

Also this all clearly says "put me in a function".  But what you need is
*almost* the BPN variable but with some prefix stripping that the BPN-logic
doesn't do (BPN only has suffix stripped, oddly).

I'd argue that the BPN logic should also strip nativesdk- prefixes, so by
fixing that the distrotools class could just get PN and BPN from the data
store and be done with it.

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20150331/e60e36c4/attachment-0002.html>