[OE-core] [PATCH] zlib: minor symbolic link issue

Burton, Ross ross.burton at intel.com
Wed May 20 14:42:19 UTC 2015


On 20 May 2015 at 10:47, Matthieu CRAPET <Matthieu.CRAPET at ingenico.com>
wrote:

> Just tell me if something is wrong, I can provide a v2 patch.
>

No, it just slipped through the cracks.

That regex looked a bit obscure, and there's a Python function we provide
that uses the Python standard library to do the same thing, so I ended up
with this locally:

# Move zlib shared libraries for target builds to $base_libdir so the
library
# can be used in early boot before $prefix is mounted.
do_install_append_class-target() {
if [ ${base_libdir} != ${libdir} ]
then
mkdir -p ${D}/${base_libdir}
mv ${D}/${libdir}/libz.so.* ${D}/${base_libdir}
libname=`readlink ${D}/${libdir}/libz.so`
ln -sf ${@oe.path.relative("${libdir}", "${base_libdir}")}/$libname
${D}${libdir}/libz.so
fi
}

Do you have any objections to this form instead?  I'm also thinking we
should rationalise the duplicated logic into a single implementation in
meta/classes/utils.bbclass...

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20150520/d89840a6/attachment-0002.html>


More information about the Openembedded-core mailing list