[OE-core] [oe-core][PATCH] systemd-serialgetty: Remove SERIAL_CONSOLE definition, because it depends of machine definition. Set it, here, can be make the value is not good.

Gary Thomas gary at mlbassoc.com
Fri May 22 13:08:55 UTC 2015


On 2015-05-22 05:11, Otavio Salvador wrote:
> On Fri, May 22, 2015 at 7:09 AM, Thomas Perrot <thomas.perrot at tupi.fr> wrote:
>> Signed-off-by: Thomas Perrot <thomas.perrot at tupi.fr>
>
> Nack! The setting here is the default if machine does not define it. I
> see no benefit in dropping this.
>

I disagree - if this variable needs a value then it should be
an error to not have one assigned.  Adding a default in an obscure
recipe (which would not have a useful value for many/most targets)
is simply wrong.

Also SERIAL_CONSOLE should now replaced by SERIAL_CONSOLES...

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------



More information about the Openembedded-core mailing list