[OE-core] [PATCH 2/2] clutter-gst-3.0: add --enable/disable-gudev

[Andreas Müller]

On Thu, Nov 12, 2015 at 10:06 AM, Robert Yang <liezhi.yang at windriver.com> wrote:
>
>
> On 11/12/2015 05:00 PM, Andreas Müller wrote:
>>
>> On Thu, Nov 12, 2015 at 9:51 AM, Robert Yang <liezhi.yang at windriver.com>
>> wrote:
>>>
>>> Fix dangling dependns on gudev, and systemd doesn't provide libgudev, so
>>> it can't be enabled when systemd either.
>>>
>>> Fixed:
>>> libtool: error: cannot find the library
>>> 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la' or unhandled argument
>>> 'tmp/sysroots/qemuarm64/usr/lib64/libgudev-1.0.la'
>>>
>>> Signed-off-by: Robert Yang <liezhi.yang at windriver.com>
>>> ---
>>>   meta/recipes-graphics/clutter/clutter-gst-3.0.inc  |   15 ++++++-
>>>   .../0001-configure.ac-add-enable-gudev.patch       |   45
>>> ++++++++++++++++++++
>>>   2 files changed, 59 insertions(+), 1 deletion(-)
>>>   create mode 100644
>>> meta/recipes-graphics/clutter/clutter-gst-3.0/0001-configure.ac-add-enable-gudev.patch
>>>
>>> diff --git a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc
>>> b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc
>>> index d4fed71..c29bc7a 100644
>>> --- a/meta/recipes-graphics/clutter/clutter-gst-3.0.inc
>>> +++ b/meta/recipes-graphics/clutter/clutter-gst-3.0.inc
>>> @@ -4,7 +4,12 @@ LICENSE = "LGPLv2+"
>>>
>>>   inherit clutter
>>>
>>> -SRC_URI +=
>>> "file://0001-Install-example-binary-needed-for-core-image-clutter.patch"
>>> +SRC_URI +=
>>> "file://0001-Install-example-binary-needed-for-core-image-clutter.patch \
>>> +            file://0001-configure.ac-add-enable-gudev.patch \
>>> +            "
>>> +
>>> +PACKAGECONFIG ??= ""
>>> +PACKAGECONFIG[gudev] = "--enable-gudev,--disable-gudev,udev"
>>>
>>>   DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad
>>> clutter-1.0"
>>>   RDEPENDS_${PN} += "gstreamer1.0-meta-base"
>>> @@ -12,6 +17,14 @@ PACKAGES  =+ "${PN}-examples"
>>>
>>>   EXTRA_OECONF += "--disable-introspection"
>>>
>>> +python () {
>>> +    if bb.utils.contains('EXTRA_OECONF', '--enable-gudev', True, False,
>>> d) and \
>>> +        bb.utils.contains('DISTRO_FEATURES', 'systemd', True, False, d):
>>> +            bb.warn("%s: gudev can't be enabled since systemd doesn't
>>> provide libgudev" % \
>>> +                    d.getVar("PN", True))
>>> +            d.appendVar('EXTRA_OECONF', ' --disable-gudev')
>>> +}
>>> +
>>
>> I think this part of the patch is wrong: You have to replace udev by
>> gudev in DEPENDS part of packageconfig above and skip python function
>
>
> I think that there is no gudev but udev ? udev provides gudev, but systemd
> only provides udev, no gudev.
>
Sorry I meant libgudev - it is in meta-oe.

I think there two cases of interest (packageconfig 'gudev' not set is
boring - so not a case :)

* distros with system: If packageconfig 'gudev' is set and meta-oe is
not layers a parse error will occure similar to your python code.
* non-systemd-distros: If packageconfig is set udev is pulled in (udev
provides gudev for non systemd distros)

Regards

Andreas