[OE-core] [OE-Core][PATCH v2] LOCKED_KEEP is undefined, so the following error will be caught.

Burton, Ross ross.burton at intel.com
Tue Nov 24 16:25:45 UTC 2015


On 23 November 2015 at 02:38, Bian Naimeng <biannm at cn.fujitsu.com> wrote:

>  /usr/lib/python2.7/site-packages/smart/transaction.py", line 1230, in run
>      locked[pkg] = (LOCKED_KEEP, None)
>
>  NameError: global name 'LOCKED_KEEP' is not defined
>
> Upstream-Status: Submitted [Smart at lists.labix.org]
>

The Upstream-Status tag should be in smart-define-LOCKED-KEEP.patch
alongside the Signed-off-by, not the commit message.  The intention is that
the patch contains who wrote it and whether it's a backport, not suitable
for upstream, and so on.

Also the commit message should be in the traditional git shortlog/longlog
form where the first line contains the recipe name and a brief summary,
something like "python-smartpm: fix runtime errors by defining LOCKED_KEEP".

Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20151124/2bf4b19c/attachment-0002.html>


More information about the Openembedded-core mailing list