[OE-core] [PATCH] populate SDK: prepare calling of bb.utils for exceptions

Richard Purdie richard.purdie at linuxfoundation.org
Fri Oct 16 10:01:28 UTC 2015


On Thu, 2015-10-15 at 12:27 -0500, Benjamin Esquivel wrote:
> +            if (bb.utils.movefile(sourcefile, destdir) == None):
> +                raise Exception("moving {} to {} failed".format(
> +                                        sourcefile, destdir))

Its a minor issue, however rightly or wrongly, the vast majority of the
code base uses "xxx %s %s" % (var, var2) instead of .format(). Is there
a reason we should be using the latter as for consistency, the former
would seem to make things more standardised?

Cheers,

Richard






More information about the Openembedded-core mailing list