[OE-core] [PATCH] python: don't append -D__SOFTFP__ to TARGET_CC_ARCH for armv6/armv7a

[Andre McCurdy]

On Mon, Oct 19, 2015 at 8:20 PM, Khem Raj <raj.khem at gmail.com> wrote:
>
>> On Oct 19, 2015, at 7:56 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
>>
>> Remove obsolete hack which seems to date back to (at least) 2009. It's
>> potentially harmful as python TARGET_CC_ARCH flags can leak through to
>> other packages via the sysroot _sysconfigdata.py.
>>
>> Signed-off-by: Andre McCurdy <armccurdy at gmail.com>
>> ---
>> meta/recipes-devtools/python/python3_3.4.3.bb | 5 +----
>> meta/recipes-devtools/python/python_2.7.9.bb  | 5 -----
>> 2 files changed, 1 insertion(+), 9 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/python/python3_3.4.3.bb b/meta/recipes-devtools/python/python3_3.4.3.bb
>> index f61d278..a33f10f 100644
>> --- a/meta/recipes-devtools/python/python3_3.4.3.bb
>> +++ b/meta/recipes-devtools/python/python3_3.4.3.bb
>> @@ -56,10 +56,7 @@ CACHED_CONFIGUREVARS = "ac_cv_have_chflags=no \
>>                 ac_cv_file__dev_ptmx=yes \
>>                 ac_cv_file__dev_ptc=no \
>> "
>> -# The 3 lines below are copied from the libffi recipe, ctypes ships its own copy of the libffi sources
>> -#Somehow gcc doesn't set __SOFTFP__ when passing -mfloatabi=softp :(
>> -TARGET_CC_ARCH_append_armv6 = " -D__SOFTFP__"
>> -TARGET_CC_ARCH_append_armv7a = " -D__SOFTFP__”
>
> this is OK although, it would be interesting to know if you build any modules that used ctypes.so

-D__SOFTFP__ shows up unexpectedly on the gcc command line when
building gpsd from meta-oe.

> even if it did work it seems wrong to pass this flag atleast it should check for callconvention=hard
>
>> +
>
>> TARGET_CC_ARCH += "-DNDEBUG -fno-inline"
>> EXTRA_OEMAKE += "CROSS_COMPILE=yes"
>> EXTRA_OECONF += "CROSSPYTHONPATH=${STAGING_LIBDIR_NATIVE}/python${PYTHON_MAJMIN}/lib-dynload/ --without-ensurepip"
>> diff --git a/meta/recipes-devtools/python/python_2.7.9.bb b/meta/recipes-devtools/python/python_2.7.9.bb
>> index f7e2f27..bc20417 100644
>> --- a/meta/recipes-devtools/python/python_2.7.9.bb
>> +++ b/meta/recipes-devtools/python/python_2.7.9.bb
>> @@ -34,11 +34,6 @@ inherit autotools multilib_header python-dir pythonnative
>>
>> CONFIGUREOPTS += " --with-system-ffi "
>>
>> -# The 3 lines below are copied from the libffi recipe, ctypes ships its own copy of the libffi sources
>> -#Somehow gcc doesn't set __SOFTFP__ when passing -mfloatabi=softp :(
>> -TARGET_CC_ARCH_append_armv6 = " -D__SOFTFP__"
>> -TARGET_CC_ARCH_append_armv7a = " -D__SOFTFP__"
>> -
>> # The following is a hack until we drop ac_cv_sizeof_off_t from site files
>> EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', 'ac_cv_sizeof_off_t=8', '', d)} ac_cv_file__dev_ptmx=yes ac_cv_file__dev_ptc=no"
>>
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>